Use Eigen expressions more effectively and kill & in code. #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick edit on @gchenfc 's recent PR #433
Be careful with having references for local variables. That's for arguments, not things on the stack. Also, though counter-intuitive I think doing transpose() twice here is actually more efficient as it will not actually store the transpose internally, which you forced. Read about Eigen expressions and tell me if I'm wrong :-)