Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Deprecation of Eliminate Methods #925

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Proper Deprecation of Eliminate Methods #925

merged 4 commits into from
Nov 12, 2021

Conversation

varunagrawal
Copy link
Collaborator

Found this while looking at elimination in GaussianFactorGraphs for MHS with @ProfFan. Let's get this out of the way so we don't have accidentally cause a dependency on this.

Fixes #889

@varunagrawal varunagrawal self-assigned this Nov 11, 2021
@varunagrawal varunagrawal added quick-review Quick and easy PR to review refactor Refactoring of code to remove rot labels Nov 11, 2021
@varunagrawal varunagrawal requested review from dellaert and removed request for gchenfc November 11, 2021 17:41
@ProfFan
Copy link
Collaborator

ProfFan commented Nov 11, 2021

@varunagrawal Could you also add the deprecation pragmas?

#if defined(__GNUC__) || defined(__clang__)
#define GTSAM_DEPRECATED __attribute__((deprecated))
#elif defined(_MSC_VER)
#define GTSAM_DEPRECATED __declspec(deprecated)
#else
#define GTSAM_DEPRECATED
#endif

@dellaert
Copy link
Member

@varunagrawal Could you also add the deprecation pragmas?

#if defined(__GNUC__) || defined(__clang__)
#define GTSAM_DEPRECATED __attribute__((deprecated))
#elif defined(_MSC_VER)
#define GTSAM_DEPRECATED __declspec(deprecated)
#else
#define GTSAM_DEPRECATED
#endif

I would think that is a different PR. That would be cool though

@varunagrawal
Copy link
Collaborator Author

I had to look up what that was but yeah it would be awesome to have that and mark the corresponding methods with it. Next PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-review Quick and easy PR to review refactor Refactoring of code to remove rot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecation] Properly mark deprecated functions in C++
3 participants