Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring cleaning: deprecate -> 4.2 #999

Merged
merged 10 commits into from
Jan 3, 2022
Merged

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 2, 2022

  • removed Lie{Scalar|Vector|Matrix} files completely
  • Changed flag to V42
  • moved a lot of deprecated things inside ifdef blocks
  • made everything compile without deprecated methods
  • removed deprecated methods from wrapper
  • I do allow AHRSFactor deprecated methods: too much work to fix

@dellaert dellaert requested a review from ProfFan January 2, 2022 21:28
@dellaert dellaert self-assigned this Jan 2, 2022
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please revert the changes in 3rdparty

gtsam/3rdparty/Eigen/Eigen/src/Core/CwiseNullaryOp.h Outdated Show resolved Hide resolved
gtsam/3rdparty/Eigen/Eigen/src/Core/DenseBase.h Outdated Show resolved Hide resolved
gtsam/3rdparty/Eigen/Eigen/src/Core/EigenBase.h Outdated Show resolved Hide resolved
gtsam/geometry/Cal3.h Outdated Show resolved Hide resolved
gtsam/geometry/Cal3Bundler.h Outdated Show resolved Hide resolved
gtsam/geometry/SimpleCamera.cpp Outdated Show resolved Hide resolved
gtsam/linear/GaussianConditional.cpp Outdated Show resolved Hide resolved
gtsam/navigation/AHRSFactor.h Show resolved Hide resolved
@dellaert
Copy link
Member Author

dellaert commented Jan 3, 2022

Wow, thanks for catching 3dparty changes. That was a blunder :-)

@dellaert dellaert merged commit 3e76824 into develop Jan 3, 2022
@dellaert dellaert deleted the feature/deprecate_in_v42 branch January 3, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants