Solved issues with packageId -> name lookup #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The program was broken due to changes in the PackageId structure. The metadata file format has a "package" key which can be used to link packageId to a displayable name. Precomputing the HashMap has a cost but future-proofs the design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love this little applicattion --- I was using it all the time.... but some time ago it stop working...
I tried to keep the changes to minimum.. ignoring indentation changes its a "6 lines fix".
I hope this helps.
Here is the commit log :-
The program was broken due to EXTERNAL changes in the PackageId structure.
The metadata file format has a "package" key which can be used to link packageId to a displayable name. Precomputing the HashMap has a cost but future-proofs the design.