js-20221021_maxim-b #84

MaximBurcev · 2022-12-01T16:40:48Z

No description provided.

dosandk · 2022-12-04T16:05:57Z

src/components/column-chart/index.js

@@ -1,74 +1,94 @@
+import fetchJson from './utils/fetch-json.js';
+
+const BACKEND_URL = 'https://course-js.javascript.ru';


это значение следует взять из переменных окружения: process.env

dosandk · 2022-12-04T16:06:02Z

src/components/column-chart/index.js

    this.label = label;
    this.link = link;
-    this.value = value;
+    this.formatHeading = formatHeading;


dosandk · 2022-12-04T16:06:55Z

src/components/column-chart/utils/fetch-json.js

@@ -0,0 +1,56 @@
+// same as fetch, but throws FetchError in case of errors


ф-ции fetchJson и escapeHTML следует вынести на уровень всех компонент и не дублировать

dosandk · 2022-12-04T16:07:21Z

src/components/notification/index.js

@@ -0,0 +1,66 @@
+export default class NotificationMessage {
+  static activeNotification;


👍 good
лайк за статическое св-во

dosandk · 2022-12-04T16:07:28Z

src/components/notification/index.js

+    this.element = element.firstElementChild;
+  }
+
+  show(parent = document.body) {


dosandk · 2022-12-04T16:07:49Z

src/components/product-form/index.js

+import escapeHtml from './utils/escape-html.js';
+import fetchJson from './utils/fetch-json.js';
+
+const IMGUR_CLIENT_ID = '28aaa2e823b03b1';


значения следует взять из переменных окружения

dosandk · 2022-12-04T16:08:30Z

src/components/product-form/utils/escape-html.js

@@ -0,0 +1,6 @@
+export default string => string


не дублируйте данные ф-ции в компонентах, вынесите на уровень выше

dosandk · 2022-12-04T16:09:20Z

src/components/tooltip/index.js

+  remove() {
+    if (this.element) {
+      this.element.remove();
+    }
  }

  destroy() {


dosandk · 2022-12-04T16:09:28Z

src/pages/dashboard/index.js

 export default class Page {
  element;
  subElements = {};
  components = {};
+  url = new URL('api/dashboard/bestsellers', BACKEND_URL);


dosandk · 2022-12-04T16:09:37Z

src/pages/dashboard/index.js

+    this.remove();
+    this.subElements = {};
+    this.element = null;
+
    for (const component of Object.values(this.components)) {


dosandk · 2022-12-04T16:10:02Z

src/pages/sales/index.js

+
+import fetchJson from '../../utils/fetch-json.js';
+
+const BACKEND_URL = 'https://course-js.javascript.ru/';


переменные окружения!

dosandk · 2022-12-04T16:10:15Z

src/pages/sales/index.js

+    return fetchJson(this.url);
+  }
+
+  initComponents () {


dosandk · 2022-12-04T16:10:25Z

src/pages/sales/index.js

+    });
+
+    const sortableTable = new SortableTable(header, {
+      url: `api/rest/orders?_start=1&_end=30&createdAt_gte=${from.toISOString()}&createdAt_lte=${to.toISOString()}`,


не забывайте про new URL

dosandk · 2022-12-04T16:10:50Z

src/pages/sales/index.js

+    this.subElements = {};
+    this.element = null;
+
+    for (const component of Object.values(this.components)) {


dosandk

не все страницы!
не вижу страниц:

categories
products
error 404

dosandk · 2022-12-08T12:05:25Z

src/components/column-chart/index.js


-const BACKEND_URL = 'https://course-js.javascript.ru';
+const BACKEND_URL = process.env.BACKEND_URL;


dosandk · 2022-12-08T12:05:37Z

src/components/product-form/index.js


-const IMGUR_CLIENT_ID = '28aaa2e823b03b1';
-const BACKEND_URL = 'https://course-js.javascript.ru';
+const IMGUR_CLIENT_ID = process.env.IMGUR_CLIENT_ID;


dosandk · 2022-12-08T12:06:03Z

src/pages/categories/index.js

+import {getSubElements} from '../../utils/helpers';
+import NotificationMessage from '../../components/notification';
+
+const BACKEND_URL = process.env.BACKEND_URL;


dosandk · 2022-12-08T12:06:08Z

src/pages/categories/index.js

@@ -0,0 +1,139 @@
+import SortableList from '../../components/sortable-list';
+import fetchJson from '../../utils/fetch-json';


dosandk · 2022-12-08T12:06:18Z

src/pages/categories/index.js

+    wrapper.innerHTML = this.template;
+    this.element = wrapper.firstChild;
+    this.subElements = getSubElements(this.element)
+    this.data = await this.getCategoryData();


dosandk · 2022-12-08T12:06:26Z

src/pages/categories/index.js

+  }
+
+  getCategories() {
+    for (const category of this.data) {


dosandk · 2022-12-08T12:06:43Z

src/pages/categories/index.js

+      return this.getSubcategoryItem(subcategory);
+    });
+
+    const sortableList = new SortableList({items});


dosandk · 2022-12-08T12:07:27Z

src/pages/categories/index.js

+  async updateCategoryOrder(data) {
+    const subcategories = [];
+    const items = data.querySelectorAll('li');
+    items.forEach((item, index) => {


может лучше воспользоваться map?

dosandk · 2022-12-08T12:08:09Z

src/pages/categories/index.js

+      });
+    });
+
+    const url = new URL('api/rest/subcategories', BACKEND_URL);


это значение лучше объявить сразу в конструкторе

dosandk · 2022-12-08T12:08:18Z

src/pages/categories/index.js

+    this.showNotification()
+  }
+
+  showNotification() {


dosandk · 2022-12-08T12:08:28Z

src/pages/dashboard/index.js


-const BACKEND_URL = 'https://course-js.javascript.ru/';
+const BACKEND_URL = process.env.BACKEND_URL;


dosandk · 2022-12-08T12:09:53Z

src/pages/products/edit/index.js

+
+  constructor (productId) {
+    const pathChunks = document.URL.split("/");
+    productId = pathChunks[pathChunks.length-1] === "add" ? "add" : pathChunks[pathChunks.length-1];


не следует мутировать аргументы ф-ции

dosandk · 2022-12-08T12:10:15Z

src/pages/products/edit/index.js

+
+  destroy() {
+    this.remove();
+    Object.keys(this.components).forEach(componentName => this.components[componentName].destroy());


dosandk

👍 good

remove components and pages

96d7aa8

MaximBurcev changed the title ~~Сборка проекта с помощью Webpack~~ js-20221021_maxim-b Dec 1, 2022

add components + add pages: dashboard, sales

c13774a

dosandk reviewed Dec 4, 2022

View reviewed changes

src/components/notification/index.js

this.element = element.firstElementChild;

}

show(parent = document.body) {

Copy link

Contributor

dosandk Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

dosandk reviewed Dec 4, 2022

View reviewed changes

src/components/tooltip/index.js

remove() {

if (this.element) {

this.element.remove();

}

}

destroy() {

Copy link

Contributor

dosandk Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

dosandk reviewed Dec 4, 2022

View reviewed changes

src/pages/sales/index.js

return fetchJson(this.url);

}

initComponents () {

Copy link

Contributor

dosandk Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

dosandk reviewed Dec 4, 2022

View reviewed changes

dosandk suggested changes Dec 4, 2022

View reviewed changes

MaximBurcev added 2 commits December 6, 2022 18:46

add products and 404

192203f

add products page

2b7502a

dosandk reviewed Dec 8, 2022

View reviewed changes

src/pages/categories/index.js

}

getCategories() {

for (const category of this.data) {

Copy link

Contributor

dosandk Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 👍

dosandk reviewed Dec 8, 2022

View reviewed changes

src/pages/categories/index.js

this.showNotification()

}

showNotification() {

Copy link

Contributor

dosandk Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

dosandk reviewed Dec 8, 2022

View reviewed changes

dosandk approved these changes Dec 8, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

js-20221021_maxim-b #84

js-20221021_maxim-b #84

MaximBurcev commented Dec 1, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk Dec 4, 2022

dosandk left a comment

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk Dec 8, 2022

dosandk left a comment

		@@ -1,74 +1,94 @@
		import fetchJson from './utils/fetch-json.js';

		const BACKEND_URL = 'https://course-js.javascript.ru';

		@@ -0,0 +1,56 @@
		// same as fetch, but throws FetchError in case of errors

		@@ -0,0 +1,66 @@
		export default class NotificationMessage {
		static activeNotification;


		import fetchJson from '../../utils/fetch-json.js';

		const BACKEND_URL = 'https://course-js.javascript.ru/';


		const BACKEND_URL = 'https://course-js.javascript.ru';
		const BACKEND_URL = process.env.BACKEND_URL;

		@@ -0,0 +1,139 @@
		import SortableList from '../../components/sortable-list';
		import fetchJson from '../../utils/fetch-json';

js-20221021_maxim-b #84

Are you sure you want to change the base?

js-20221021_maxim-b #84

Conversation

MaximBurcev commented Dec 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dosandk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dosandk left a comment

Choose a reason for hiding this comment