Add pages and more #95

Cat-Malum · 2023-02-01T18:32:20Z

Не смог разобраться с notification

dosandk · 2023-03-01T10:46:25Z

src/components/double-slider/index.js

@@ -0,0 +1,178 @@
+export default class DoubleSlider {
+	element;


нужно что-то сделать с форматированием кода, для JavaScript обычно принято использовать 1 таб в размере 2х пробелов

dosandk · 2023-03-01T10:46:41Z

src/components/notification/index.js

@@ -0,0 +1,66 @@
+export default class NotificationMessage {
+	static activeNotification;


dosandk · 2023-03-01T10:47:00Z

src/components/notification/index.js

+		duration = 2000,
+		type = 'success'
+	} = {}) {
+		this.string = string;


лучше назвать это поле message

dosandk · 2023-03-01T10:48:01Z

src/components/notification/index.js

+		this.element = wrapper.firstElementChild;
+	}
+
+	show(target = document.body) {


dosandk · 2023-03-01T10:50:01Z

src/components/sortable-list/index.js

-    this.remove();
-  }
+  	element;
+	draggingElem;


нельзя в проекте смешивать отступы табуляций и пробелов!
либо то либо то!

dosandk · 2023-03-01T10:50:24Z

src/components/sortable-list/index.js

+	}
+
+	moveDraggingAt(clientX, clientY) {
+		// this.draggingElem.style.left = `${clientX - this.pointerShift.x}px`;


не оставляйте закоменченый код

dosandk · 2023-03-01T10:50:44Z

src/components/sortable-table/index.js

@@ -1,14 +1,14 @@
 import fetchJson from "../../utils/fetch-json.js";

-const BACKEND_URL = 'https://course-js.javascript.ru';
+const BACKEND_URL = process.env.BACKEND_URL;


👍 good
лайк за использование переменных окружения

dosandk · 2023-03-01T10:51:25Z

src/components/sortable-table/index.js

-      </div>`
-    ).join('');
+    return data.map(item => {
+      if (window.location.pathname === '/sales') {


🔴 please don't do this
так делать категорически нельзя! нельзя просто так взять и обратится из компонента к window.location

подумайте, может стоит передать какой-то параметр для определения что использовать div или a тег

dosandk · 2023-03-01T10:52:20Z

src/index.js

+
+const toggleSidebar = document.querySelector('.sidebar__toggler');
+
+toggleSidebar.addEventListener('click', () => {


dosandk · 2023-03-01T10:53:22Z

src/index.js

+
+  for (const page of pages) {
+    if (pageName.includes(page.dataset.page)) {
+      page.parentElement.classList.add('active');


🔴 please don't do this
так делать нельзя! нельзя обращаться к parentElement
найдите данный эл-т с помощью селектора

dosandk · 2023-03-01T10:53:31Z

src/pages/categories/index.js

+export default class Page {
+	element;
+	components = {};
+	url = new URL('api/rest/categories', BACKEND_URL);


dosandk · 2023-03-01T10:54:29Z

src/pages/categories/index.js

+	}
+
+	destroy() {
+		for (const component of Object.values(this.components)) {


dosandk · 2023-03-01T10:55:37Z

src/pages/dashboard/index.js

@@ -41,7 +43,8 @@ export default class Page {

  async initComponents () {
    const to = new Date();
-    const from = new Date(to.getTime() - (30 * 24 * 60 * 60 * 1000));
+    const from = new Date(to.getTime() - (30 * 30 * 60 * 60 * 1000));


🔴 please don't do this
так делать нельзя! подумайте как взять временной диапазон в 1 месяц (в месяце бывает 30 дней, 31, 28 и даже 29)

dosandk · 2023-03-01T10:55:43Z

src/pages/dashboard/index.js

@@ -73,45 +76,40 @@ export default class Page {
      value: customersData.reduce((accum, item) => accum + item),
    });



dosandk · 2023-03-01T10:56:02Z

src/pages/products/edit/index.js

+	components = {};
+
+	constructor(productId = '') {
+		this.productId = productId;


dosandk · 2023-03-01T10:56:34Z

src/pages/products/edit/index.js

+	}
+
+	async initComponents(productId = '') {
+		const productData = await new ProductForm(productId);


🔴 please don't do this
так работать не будет await new ProductForm(productId), так делать не стоит
не бывает асинхронных конструкторов

dosandk · 2023-03-01T10:57:56Z

src/pages/sales/index.js

+	}
+
+	renderComponents() {
+		const topPanel = this.element.querySelector('.content__top-panel');


было бы неплохо делать рендер компонент динамически - через цикл

dosandk · 2023-03-01T10:58:47Z

src/router/render-page.js

-  const page = new Page();
+  let page;
+
+  if (path === 'products/edit') {


🔴 please don't do this
так делать не следует
передавайте match во все страницы, просто обрабатывайте этот аргумент только в тех страницах где это нужно!

dosandk

👍 good
нужно поправить форматирование кода! отступы

Add pages and more

22ba034

dosandk reviewed Mar 1, 2023

View reviewed changes

src/components/notification/index.js

this.element = wrapper.firstElementChild;

}

show(target = document.body) {

Copy link

Contributor

dosandk Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

dosandk reviewed Mar 1, 2023

View reviewed changes

src/pages/categories/index.js

}

destroy() {

for (const component of Object.values(this.components)) {

Copy link

Contributor

dosandk Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

dosandk reviewed Mar 1, 2023

View reviewed changes

src/pages/products/edit/index.js

components = {};

constructor(productId = '') {

this.productId = productId;

Copy link

Contributor

dosandk Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

dosandk reviewed Mar 1, 2023

View reviewed changes

dosandk approved these changes Mar 1, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pages and more #95

Add pages and more #95

Cat-Malum commented Feb 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk Mar 1, 2023 •

edited

Loading

dosandk Mar 1, 2023

dosandk Mar 1, 2023

dosandk left a comment

		@@ -0,0 +1,178 @@
		export default class DoubleSlider {
		element;

		@@ -0,0 +1,66 @@
		export default class NotificationMessage {
		static activeNotification;


		const toggleSidebar = document.querySelector('.sidebar__toggler');

		toggleSidebar.addEventListener('click', () => {

		@@ -73,45 +76,40 @@ export default class Page {
		value: customersData.reduce((accum, item) => accum + item),
		});

Add pages and more #95

Are you sure you want to change the base?

Add pages and more #95

Conversation

Cat-Malum commented Feb 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dosandk Mar 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dosandk left a comment

Choose a reason for hiding this comment

dosandk Mar 1, 2023 •

edited

Loading