-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing the nuget package #161
Comments
I have this problem reversed. My project is NOT signed, nor ise EFCore.BulkExtensions. But God knows why, its referencing FastMember SIGNED, Please release a nuget package referencing UNSIGNED FastMember package too, thank you. |
In latest Nuget FastMember.Signed is replaced with FastMember. |
@borisdj Would you accept a PR that handles this? The idea would be to fix the AssemblyVersion and only increase it when the major version is increased (i.e. when breaking changes are introduced). This gives what I'd consider the best experience: You get a warning if you try to use incompatible versions, which you can explicitly ignore with binding redirects. For minor versions if two NuGet packages require different versions, NuGet resolves the higher version which is then installed. No binding redirects are needed and everything just works as it should. I'd simply add an additional csproj, but share all the relevant information between the two projects to avoid duplication. |
Please sign this package. All MS packages are signed and other large OSS projects are doing this. (e.g. Json.NET) If we are doing semver here, it's recommend to use only the major version name in your assembly. (so 1.0.0.0, 2.0.0.0 and currently 3.0.0.0) - also others are doing that (like Json.NET) |
@borisdj You don't need a certificate.
Diff of the project file:
|
@SailorTurkey All Microsoft packages have a strong name and you can consume them in a project, which is not strong name signed. @borisdj If you like I can create a pull request. |
5.0.6 is now Strong named. |
Yes, just check in the generated snk without a password. See my comment from June 23. |
Finished, thx for suggestion. |
Thanks for this package! 👍 |
For those who need a signed assembly for an older version (in my case 2.4.1 because of EF Core 2.1), execute the following commands in an empty temp-directory (adjust):
add the dll to your repository and then reference it in all projects where you need it:
|
Could you please sign the nuget package. I'm getting errors when including your package in a project:
Error CS8002 Referenced assembly 'EFCore.BulkExtensions, Version=2.4.3.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.
The text was updated successfully, but these errors were encountered: