Removed generated files from repository but keep publishing them #18
Conversation
okonet
commented
Sep 24, 2015
okonet
commented
- removed whitespace from package.json description
| "node-libs-browser": "^0.5.2", | ||
| "react-tools": "*", | ||
| "webpack": "^1.10.0", | ||
| "webpack-dev-server": "^1.10.1" | ||
| }, | ||
| "dependencies": { | ||
| "peerDependencies": { | ||
| "react": "^0.13.3" |
There was a problem hiding this comment.
This was causing issues with duplicate Reacts.
I had it before, and removed it intentionally.
If it isn't messing up the new build thing, better remove it?
Or any other ideas? (we at least need a or 0.14-rc thing)
There was a problem hiding this comment.
Only if you have it in dependencies. I've put into peerDependencies so it will not be installed twice.
There was a problem hiding this comment.
Hmm, I think I had a decent reason of taking it out of peerDependencies :)
There was a problem hiding this comment.
This is strange because in this case you don't define the deps of React at all, which can cause more trouble.
https://nodejs.org/en/blog/npm/peer-dependencies/
also packages like this: YahooArchive/flux-router-component#33 also moved it to peerDependecies
So I think we're safe to go here.
There was a problem hiding this comment.
Accepted it as-is, also added 0.14 as optional dependency.
There was a problem hiding this comment.
Yeah, I've noticed it. Thanks! 👍
