(feature) (types) Add 'dnf' type #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
skylarmacdonald
added
enhancement
|
Hello and thank you for this contribution! Would you be able to take a look at adding a test? The yum test should give you a good starting point. |
github-actions
bot
added
the
documentation
|
(And I will investigate why the Danger workflow is failing...!) |
|
Test added |
|
Is there something else I need to fix so the rest of your tests pass? |
|
Not sure what the problem is with Danger, so I will merge anyway. All looks good to me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a copy/paste of the existing
yumtype. Closes #34