Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team shifts: implement marking shifts for sale #882

Closed
wants to merge 1 commit into from

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Aug 26, 2021

A common occurence is that not enough people volunteer for shifts at
first, and then the few volunteers take all the shifts (too many). Then
late comers aren't able to take any shifts.

This commit implements a third state for shift assignment: for sale. A
shift marked for sale means the team member is able to take the shift if
need be, but would rather someone else takes the shift. Another team
member will be able to take shifts at the same time even if the required
number of people are met.

The current semantics is for-sale shifts are replaced eagerly. Another
possible implementation would be to only replace for-sale shifts if the
number of required people is met.

I have not tested this #yolo

A common occurence is that not enough people volunteer for shifts at
first, and then the few volunteers take all the shifts (too many). Then
late comers aren't able to take any shifts.

This commit implements a third state for shift assignment: for sale. A
shift marked for sale means the team member is able to take the shift if
need be, but would rather someone else takes the shift. Another team
member will be able to take shifts at the same time even if the required
number of people are met.

The current semantics is for-sale shifts are replaced eagerly. Another
possible implementation would be to only replace for-sale shifts if the
number of required people is met.
@tykling
Copy link
Member

tykling commented Sep 20, 2024

This would be nice to get in, but it needs a rebase and needs to be properly tested. Are you still interested in working on this @reynir or should we try to find someone else to get it merged?

@reynir
Copy link
Contributor Author

reynir commented Sep 20, 2024

Thanks. At this time I'm not motivated enough to work on it, but it would be great if someone can bring it forward!

@tykling
Copy link
Member

tykling commented Sep 22, 2024

closing for now, feel free to reopen, or open an issue so the idea doesn't get lost 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants