-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Talos: Upgrade node-gyp to v7 (and more)
We were using node-gyp v3.8.0, which has a bug preventing it to be used with Python3 However, we build on Alpine Linux, which requires Python3. As the bug was showing up while building node-sass, the later was also updated to a compatible version. It also helps as the node-sass version was ancient and did not work with all recent node.js versions. However, as `react-scripts` depended on `sass-loader` v8, and `sass-loader` depends on `node-sass` v4.x.x, we also had to bump `react-scripts`. The first version to support `sass-loader` v11 was v4.0.2 and v4.0.3 is the latest version as of the time of this commit. This then led to facebook/create-react-app#9937 which is worked around by simply moving the assets.
- Loading branch information
Showing
7 changed files
with
15,372 additions
and
9,160 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters