Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

license creation failing because of wrong path #58

Merged
merged 57 commits into from
Mar 28, 2024
Merged

license creation failing because of wrong path #58

merged 57 commits into from
Mar 28, 2024

Conversation

ant-u
Copy link
Collaborator

@ant-u ant-u commented Mar 18, 2024 •
edited
Loading

Changed license file creation to only be triggered if checks succeed or end with warnings. Added assertion for path to exist when creating file so even if it doesn't, the software doesn't crash.

dependabot bot and others added 30 commits October 2, 2023 22:41
@dependabot
Update scancode-toolkit requirement from <=31.2.6 to <=32.0.7
be4a47c 
Updates the requirements on [scancode-toolkit](https://github.com/nexB/scancode-toolkit) to permit the latest version.
- [Release notes](https://github.com/nexB/scancode-toolkit/releases)
- [Changelog](https://github.com/nexB/scancode-toolkit/blob/develop/CHANGELOG.rst)
- [Commits](aboutcode-org/scancode-toolkit@v1.0.0...v32.0.7)

---
updated-dependencies:
- dependency-name: scancode-toolkit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@ct2034
working from 32.0.7
53dc988 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
is_license_text check fixed with new result semantics
85df286 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
linting fix
db494df 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
handling of ignored files
ca0e3e1 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
formatting
c53c22b 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
this is all WIP
073e6fb 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
Merge branch 'main' into dependabot/pip/scancode-toolkit-lte-32.0.7
6555c19
@ct2034
Unnecessary "else" after "return"
5312b77 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
still bad with 32.0.8
d747147 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
ignoring those rules
8f18304 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ant-u
Merge branch 'main' into dependabot/pip/scancode-toolkit-lte-32.0.7
dada029
@ant-u
changed method get_spdx_license_name back, WIP
f633c28 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
scancode get_copyrights function filtering word 'anything', changed t…
1e7a499 
…o second

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
linter issues
b5d3b25 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Added spaces around comment for scancode to recognize copyright message
fd8d6de 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' of https://github.com/boschresearch/ros_license_t…
af457d3 
…oolkit into dependabot/pip/scancode-toolkit-lte-32.0.7

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added check for only one license text which is in spdx to start handl…
648de94 
…ing wrong tags as the license of the file

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
When only one SPDX License File exists, make a warning to change the …
59be16e 
…wrong tag

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Added check if multiple files exist
27393ff 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
restructured LicenseTextExistsCheck
28cede1 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
reverted restructure of check since pytest has trouble with it
eec394c 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
moved LicenseTextExists checks to seperate function
b7859b4 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
made own evaluation function for licenseInCodeCheck
9aefe6a 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added irgnore flag for too many attributes localy to package.py since…
945cd93 
… this is the only place where saving inofficial licenses makes sense

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Converted check_licenses mehtod to function
622738e 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
restructured Check LicensesInCode and TextExists to work with attribu…
75c2d63 
…tes instead of local vars

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added test for two licenses with both tags not in spdx
6c9ba21 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed license from test to MPL
5af585d 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Added negative test for two not in spdx tags but one for own license …
89f05d9 
…file

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' into feature/error_for_spdx_license_and_tag
2c861e9 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
deleted unnecessary attribute from pull request
cecde49 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u ant-u linked an issue Mar 18, 2024 that may be closed by this pull request
License creation fails with "AssertionError: License text file must be defined." #45
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
634 595 94% 90% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: fe4c7db by action🐍

ant-u and others added 8 commits March 18, 2024 11:32
@ant-u
License creation only when checks not failing
8f72294 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
introduced .scanignore file, keeping local var for ignoring default f…
371d631 
…iles.

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Added list of default ignored items to readme
0a9573b 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' into feature/handling-false-positives
60b824e 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge pull request #54 from boschresearch/feature/error_for_spdx_lice…
87b062a 
…nse_and_tag

Feature/error for spdx license and tag
@ant-u
Merge branch 'main' into feature/license-creation-checking-path
3d912da
@ant-u
Merge pull request #53 from boschresearch/feature/handling-false-posi…
0cb67b7 
…tives

Feature/handling false positives
@ant-u
Merge branch 'main' into feature/license-creation-checking-path
e42f2df
@ant-u ant-u self-assigned this Mar 19, 2024
@ant-u
Feature: add check for every license has a matching tag (#55)
90afb3e 
* added check for lincense files not covered by any tag
* Added test for too many License files
* Added inofficial license check in LicenseFileReferenced to decide between error and warning. Introduced function for path is parent or child

---------

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' into feature/license-creation-checking-path
8156f63
@ant-u ant-u requested a review from ct2034 March 19, 2024 09:06
@ant-u ant-u marked this pull request as ready for review March 19, 2024 09:06
ct2034
ct2034 requested changes Mar 19, 2024
View reviewed changes
src/ros_license_toolkit/main.py Outdated Show resolved Hide resolved
@ant-u
changed doc string of generate_copyright_file
22d66e8 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u ant-u requested a review from ct2034 March 19, 2024 13:50
ct2034
ct2034 requested changes Mar 28, 2024
View reviewed changes
src/ros_license_toolkit/main.py Show resolved Hide resolved
src/ros_license_toolkit/package.py Outdated Show resolved Hide resolved
ant-u and others added 3 commits March 28, 2024 15:29
@ant-u
implemented requested changes
e6b3892 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
fixing linter and version issues
b6a6758 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ct2034
Merge branch 'main' into feature/license-creation-checking-path
746c225
ct2034
ct2034 requested changes Mar 28, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@ct2034 ct2034 merged commit 4febc86 into main Mar 28, 2024
11 of 12 checks passed
@ct2034 ct2034 deleted the feature/license-creation-checking-path branch March 28, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ct2034 ct2034 ct2034 requested changes

Assignees

@ant-u ant-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License creation fails with "AssertionError: License text file must be defined."
2 participants
@ant-u @ct2034