Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/check fails with NoneType #64

Merged
merged 55 commits into from
Mar 28, 2024
Merged

Bugfix/check fails with NoneType #64

merged 55 commits into from
Mar 28, 2024

Commits on Oct 2, 2023

  1. Update scancode-toolkit requirement from <=31.2.6 to <=32.0.7 

    Updates the requirements on [scancode-toolkit](https://github.com/nexB/scancode-toolkit) to permit the latest version.
- [Release notes](https://github.com/nexB/scancode-toolkit/releases)
- [Changelog](https://github.com/nexB/scancode-toolkit/blob/develop/CHANGELOG.rst)
- [Commits](aboutcode-org/scancode-toolkit@v1.0.0...v32.0.7)

---
updated-dependencies:
- dependency-name: scancode-toolkit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    be4a47c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. working from 32.0.7 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    53dc988 View commit details
    Browse the repository at this point in the history

  2. is_license_text check fixed with new result semantics 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    85df286 View commit details
    Browse the repository at this point in the history

  3. linting fix 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    db494df View commit details
    Browse the repository at this point in the history

  4. handling of ignored files 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ca0e3e1 View commit details
    Browse the repository at this point in the history

  5. formatting 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c53c22b View commit details
    Browse the repository at this point in the history

  6. this is all WIP 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    073e6fb View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge branch 'main' into dependabot/pip/scancode-toolkit-lte-32.0.7

    @ct2034
    ct2034 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6555c19 View commit details
    Browse the repository at this point in the history

  2. Unnecessary "else" after "return" 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    5312b77 View commit details
    Browse the repository at this point in the history

  3. still bad with 32.0.8 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d747147 View commit details
    Browse the repository at this point in the history

  4. ignoring those rules 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    8f18304 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'main' into dependabot/pip/scancode-toolkit-lte-32.0.7

    @ant-u
    ant-u authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    dada029 View commit details
    Browse the repository at this point in the history

  2. changed method get_spdx_license_name back, WIP 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f633c28 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. scancode get_copyrights function filtering word 'anything', changed t… 

    …o second

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1e7a499 View commit details
    Browse the repository at this point in the history

  2. linter issues 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b5d3b25 View commit details
    Browse the repository at this point in the history

  3. Added spaces around comment for scancode to recognize copyright message 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    fd8d6de View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/boschresearch/ros_license_t… 

    …oolkit into dependabot/pip/scancode-toolkit-lte-32.0.7

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    af457d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. added check for only one license text which is in spdx to start handl… 

    …ing wrong tags as the license of the file

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    648de94 View commit details
    Browse the repository at this point in the history

  2. When only one SPDX License File exists, make a warning to change the … 

    …wrong tag

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    59be16e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Added check if multiple files exist 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    27393ff View commit details
    Browse the repository at this point in the history

  2. restructured LicenseTextExistsCheck 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    28cede1 View commit details
    Browse the repository at this point in the history

  3. reverted restructure of check since pytest has trouble with it 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    eec394c View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. moved LicenseTextExists checks to seperate function 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b7859b4 View commit details
    Browse the repository at this point in the history

  2. made own evaluation function for licenseInCodeCheck 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9aefe6a View commit details
    Browse the repository at this point in the history

  3. added irgnore flag for too many attributes localy to package.py since… 

    … this is the only place where saving inofficial licenses makes sense

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    945cd93 View commit details
    Browse the repository at this point in the history

  4. Converted check_licenses mehtod to function 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    622738e View commit details
    Browse the repository at this point in the history

  5. restructured Check LicensesInCode and TextExists to work with attribu… 

    …tes instead of local vars

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    75c2d63 View commit details
    Browse the repository at this point in the history

  6. added test for two licenses with both tags not in spdx 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6c9ba21 View commit details
    Browse the repository at this point in the history

  7. changed license from test to MPL 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5af585d View commit details
    Browse the repository at this point in the history

  8. Added negative test for two not in spdx tags but one for own license … 

    …file

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    89f05d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. added test for ignoring contents of readme 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    f51e03b View commit details
    Browse the repository at this point in the history

  2. added ignore file in json format to set all files, types and folders … 

    …for ignoring

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4590a29 View commit details
    Browse the repository at this point in the history

  3. added test for hidden folder that should also be ignored (simulating … 

    …git folder). Changed format of ignore file

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    07f813e View commit details
    Browse the repository at this point in the history

  4. merged two lines 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4ee05fe View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. changed check for LicenceTag to Fail if tag and file are not same lic… 

    …ense but both are SPDX

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    065ff46 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Documenting requirements for pypi update (#56) 

    Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
    @ct2034
    ct2034 authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    87bd4fc View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'main' into feature/handling-false-positives 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    690dfc6 View commit details
    Browse the repository at this point in the history

  2. linter issues 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3a99d0e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/error_for_spdx_license_and_tag 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2c861e9 View commit details
    Browse the repository at this point in the history

  4. deleted unnecessary attribute from pull request 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cecde49 View commit details
    Browse the repository at this point in the history

  5. Added check for LicenenseInCode if src file has a license declaration… 

    … in SPDX. Otherwise, display warning

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3ab9062 View commit details
    Browse the repository at this point in the history

  6. introduced .scanignore file, keeping local var for ignoring default f… 

    …iles.

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    371d631 View commit details
    Browse the repository at this point in the history

  7. Added list of default ignored items to readme 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0a9573b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into feature/handling-false-positives 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    60b824e View commit details
    Browse the repository at this point in the history

  9. Merge pull request #54 from boschresearch/feature/error_for_spdx_lice… 

    …nse_and_tag

Feature/error for spdx license and tag
    @ant-u
    ant-u authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    87b062a View commit details
    Browse the repository at this point in the history

  10. Merge pull request #53 from boschresearch/feature/handling-false-posi… 

    …tives

Feature/handling false positives
    @ant-u
    ant-u authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0cb67b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge branch 'main' into bugfix/check_fails_with_nonetype

    @ant-u
    ant-u authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    665a0b6 View commit details
    Browse the repository at this point in the history

  2. Feature: add check for every license has a matching tag (#55) 

    * added check for lincense files not covered by any tag
* Added test for too many License files
* Added inofficial license check in LicenseFileReferenced to decide between error and warning. Introduced function for path is parent or child

---------

Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    90afb3e View commit details
    Browse the repository at this point in the history

  3. removed license file, adapted linting issues 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    855debb View commit details
    Browse the repository at this point in the history

  4. removed extra code file from unkown license package 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8f83c1f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into bugfix/check_fails_with_nonetype

    @ant-u
    ant-u authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3569882 View commit details
    Browse the repository at this point in the history

  6. Added calls for test 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ff8816b View commit details
    Browse the repository at this point in the history

  7. removed trailing whitespace 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9bb37b0 View commit details
    Browse the repository at this point in the history

  8. removed check for files with no license 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e9fbcf3 View commit details
    Browse the repository at this point in the history

  9. Adapted check 

    Signed-off-by: Anton Utz <uta5fe@bosch.com>
    @ant-u
    ant-u committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    56f8712 View commit details
    Browse the repository at this point in the history