V3 #85
Open
V3 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgirault
force-pushed
the
v3
branch
2 times, most recently
from
e8025d6 to
8ceb717
Compare
|
Hello, |
|
Hi, |
felixgirault
force-pushed
the
v3
branch
4 times, most recently
from
48b3072 to
0b4c213
Compare
felixgirault
force-pushed
the
v3
branch
3 times, most recently
from
b5d6f9a to
dc28fdd
Compare
* preact * react-modal
Another option would have been to make every class name fully configurable (the whole class name instead of just the prefix), but the cost of it would outweigh the gain. Also, the `stylePrefix` option wasn't even documented, so we're betting on the fact that very few people are actually using it, if any.
This change is to better align with CNIL's recommendations. For now, the change has been made kind of brutally, so some things don't make sense (i.e. purposes can have purposes...). Further changes will fix the remaining problems.
This seems to be the most broadly used naming.
For now, they are just set to empty strings, but this allows to see what's missing at a glance.
The previous mechanics were overly complicated for such a small app, and pretty unlegible.
@see RGAA 7.1
* using a page object to abstract things away * mocking an HTML page to load custom configs
The default ones were merged over the ones from the config.
The default banner styles don't depend on the screen width anymore. This avoids a potential mismatch between the media queries and the public configuration variables, causing the banner to overflow in some cases. The distinction between regular and "forced" banner is also removed, as the backdrop on forced banners is distictive enough.
This shaves a bit of weight on the final bundle. Compat was used so users could import Orejime inside a React app, but we're not supporting this usage anymore.
* Using type "orejime" instead of "opt-in" to make things clearer * Setting the type attribute to "text/javascript" by default, removing the need to set it explicitly to begin with
felixgirault
force-pushed
the
v3
branch
4 times, most recently
from
fb856e6 to
a7496e8
Compare
This commit is obviously too big but also hard to split. The main goal is to build standalone modules instead of using a complicated async loading workflow, as to ease development, optimization, and usage. This also include a huge rewrite of the docs to accommodate for the change and make them more readable.
Incidentally removed an unused method of the manager
Using the default settings shaves off more that 2kb from gzipped bundles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.