Merge pull request #637 from bosonprotocol/reserve-range-CEI

Fix code scanning alert - Reentrancy vulnerabilities
bosonprotocol · Jun 7, 2023 · 451dc3d · 451dc3d
2 parents 66225eb + 00dfcd6
commit 451dc3d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/contracts/protocol/bases/OfferBase.sol b/contracts/protocol/bases/OfferBase.sol
@@ -322,9 +322,6 @@ contract OfferBase is ProtocolBase, IBosonOfferEvents {
         // _to must be the contract address or the contract owner
         require(_to == address(bosonVoucher) || _to == sender, INVALID_TO_ADDRESS);
 
-        // Call reserveRange on voucher
-        bosonVoucher.reserveRange(_offerId, _startId, _length, _to);
-
         // increase exchangeIds
         pc.nextExchangeId = _startId + _length;
 
@@ -333,6 +330,9 @@ contract OfferBase is ProtocolBase, IBosonOfferEvents {
             offer.quantityAvailable -= _length;
         }
 
+        // Call reserveRange on voucher
+        bosonVoucher.reserveRange(_offerId, _startId, _length, _to);
+
         // Notify external observers
         emit RangeReserved(_offerId, offer.sellerId, _startId, _startId + _length - 1, _to, sender);
     }