Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHF-02C] Redundant Parenthesis Statement #739

Closed
zajck opened this issue Aug 1, 2023 · 0 comments · Fixed by #750
Closed

[PHF-02C] Redundant Parenthesis Statement #739

zajck opened this issue Aug 1, 2023 · 0 comments · Fixed by #750
Assignees
@zajck
Labels
enhancement New feature or request v2.3.0

Comments

@zajck
Copy link
Member

zajck commented Aug 1, 2023

PHF-02C: Redundant Parenthesis Statement

Type Severity Location
Code Style PauseHandlerFacet.sol:L89

Description:

The referenced statement is redundantly wrapped in parenthesis (()).

Example:

if ((status.pauseScenario & (1 << i)) != 0) {

Recommendation:

We advise them to be safely omitted, increasing the legibility of the codebase.
@zajck zajck added enhancement New feature or request v2.3.0 labels Aug 1, 2023
@zajck zajck self-assigned this Aug 3, 2023
zajck added a commit that referenced this issue Aug 3, 2023
@zajck
Fix #739
63d941f
@zajck zajck mentioned this issue Aug 3, 2023
Merged
zajck added a commit that referenced this issue Aug 17, 2023
@zajck @levalleux-ludo
Remediate [BVR-02C, EHF-02C, PHF-02C] Redundant Parenthesis Statement (…
827a2a0 
…#750)

* fix #733

* fix #735

* Fix #739

---------

Co-authored-by: Ludovic Levalleux <levalleux_ludo@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zajck zajck

Labels
enhancement New feature or request v2.3.0
Projects
None yet
Milestone
No milestone
1 participant
@zajck