Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong price used in release funds #902

Closed
zajck opened this issue Feb 12, 2024 · 1 comment · Fixed by #904
Closed

Wrong price used in release funds #902

zajck opened this issue Feb 12, 2024 · 1 comment · Fixed by #904
Assignees
Labels
bug Something isn't working v2.4.0

Comments

@zajck
Copy link
Member

zajck commented Feb 12, 2024

The release funds method always uses the original offer price:

This is incorrect for offers with price discovery and offers with sequential commit since the last price is likely to be different from the starting price.

First the test suite should be updated and then the contracts should be fixed to release the correct amount.

@zajck zajck added bug Something isn't working v2.4.0 labels Feb 12, 2024
@zajck
Copy link
Member Author

zajck commented Feb 14, 2024

This introduces another constraint - each secondary price should be at least equal to buyer cancelation penalty to work when the final state is canceled.

@zajck zajck self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant