Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release funds #904

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Fix release funds #904

merged 6 commits into from
Feb 16, 2024

Conversation

zajck
Copy link
Member

@zajck zajck commented Feb 14, 2024

Fix #902

@zajck zajck marked this pull request as ready for review February 16, 2024 08:31
@zajck zajck self-assigned this Feb 16, 2024
@zajck zajck added bug Something isn't working v2.4.0 labels Feb 16, 2024
@coveralls
Copy link

Coverage Status

coverage: 98.927% (+0.002%) from 98.925%
when pulling 7499ee7 on sequential-commit-revision
into 9ed49d7 on main.

levalleux-ludo
levalleux-ludo approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 1 comment (possible gas optim?)

contracts/protocol/libs/FundsLib.sol Show resolved Hide resolved
@zajck zajck merged commit da52f24 into main Feb 16, 2024
19 checks passed
@zajck zajck deleted the sequential-commit-revision branch February 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

@albertfolch-redeemeum albertfolch-redeemeum albertfolch-redeemeum approved these changes

Assignees

@zajck zajck

Labels
bug Something isn't working v2.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong price used in release funds
4 participants
@zajck @coveralls @levalleux-ludo @albertfolch-redeemeum