Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug in update seller #624

Merged
merged 1 commit into from
May 9, 2023
Merged

Fix the bug in update seller #624

merged 1 commit into from
May 9, 2023

Conversation

zajck
Copy link
Member

@zajck zajck commented May 9, 2023

Fixes #623

@zajck zajck added the bug Something isn't working label May 9, 2023
@zajck zajck self-assigned this May 9, 2023
@zajck zajck requested review from anajuliabit and mischat May 9, 2023 10:27
anajuliabit
anajuliabit approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@anajuliabit anajuliabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zajck zajck added the v2.2.1 label May 9, 2023
mischat
mischat approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, let's get it into v2.2.1-rc* and create a new RC.

Thanks

@mischat mischat merged commit e766862 into main May 9, 2023
@mischat mischat deleted the fix-update-seller branch May 9, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischat mischat mischat approved these changes

@anajuliabit anajuliabit anajuliabit approved these changes

Assignees

@zajck zajck

Labels
bug Something isn't working v2.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot update seller back to the same authTokenId & authTokenType
3 participants
@zajck @mischat @anajuliabit