Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate twinIdsByTokenAddressAndBySeller #628

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Deprecate twinIdsByTokenAddressAndBySeller #628

merged 3 commits into from
Jun 2, 2023

Conversation

anajuliabit
Copy link
Contributor

@anajuliabit anajuliabit commented May 10, 2023 •
edited
Loading

This PR deprecate twinIdsByTokenAddressAndBySeller and remove the redundant check on twin creation.

Fix #596

@anajuliabit anajuliabit requested review from zajck, mischat and mattyboomboom and removed request for mattyboomboom May 10, 2023 13:21
zajck
zajck approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@zajck zajck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zajck zajck added the v2.3.0 label May 11, 2023
@anajuliabit anajuliabit self-assigned this May 11, 2023
@coveralls
Copy link

coveralls commented May 31, 2023 •
edited
Loading

Coverage Status

coverage: 99.736% (+0.03%) from 99.708% when pulling 079a00c on remove-redundant-check into 1e5dc02 on main.

mischat
mischat approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mischat mischat merged commit dbb93c1 into main Jun 2, 2023
@mischat mischat deleted the remove-redundant-check branch June 2, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischat mischat mischat approved these changes

@zajck zajck zajck approved these changes

Assignees

@anajuliabit anajuliabit

Labels
v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove redundant check on createTwinInternal
4 participants
@anajuliabit @coveralls @mischat @zajck