Update solidity, hardhat, slither CI #632
Conversation
|
could you fix coverage? |
zajck
force-pushed
the
upgrade-solidity-and-hardhat-version
branch
from
b284ad9
to
98a6d30
Compare
zajck
force-pushed
the
upgrade-solidity-and-hardhat-version
branch
from
82df34f
to
50ecd95
Compare
| // Reverts with default message | ||
| revert(FUNCTION_CALL_NOT_SUCCESSFUL); | ||
| } | ||
| } |
There was a problem hiding this comment.
this seems like a step backwards, I wonder why this is like this ?
There was a problem hiding this comment.
returnData contains some bytes at the beginning, which are not the actual revert reason.
When it's cast to string (string(returnData)) solidity does not really care that the bytes are not valid string bytes. So if that's then passed as a revert message, the client cannot decode it into a valid string.
For some reason, this wasn't a problem in the past (probably hardhat/ethers ignored the invalid part of the string), but now it is.
In any case, this is now the correct implementation for bubbling up the error, i.e. the error is exactly the same as the one, raised by the contract that reverted.
There was a problem hiding this comment.
And without this code change, some tests fail.
| revert(string(error)); | ||
| assembly { | ||
| revert(add(32, error), mload(error)) | ||
| } |
There was a problem hiding this comment.
This happens in a few places ...
Closes #611
The latest solidity version is 0.8.20, but 0.8.18 is the latest fully supported by hardhat (and also recommended by slither).
In addition to updating the compiler version I made these changes:
hardhat-waffletohardhat-toolbox. This will allow us to use predicates when testing events. Migration lead to the following changes.JewelerLib.sol,MetaTransactionsHandlerFacet.solandProtocolInitializationHandlerFacet.solhardhat.config.jswe don't need to require separate packages anymore@ethereum-waffle/mock-contractso mocked contracts inbosonVoucherTest.jsstill workI tried compilation viaIR, which resulted in a larger contract size. Before using that feature we need to investigate what is the proper optimization sequence.