2.2.1 Release #633
Merged
2.2.1 Release #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anajuliabit
suggested changes
May 12, 2023
| ], | ||
| remove: [], | ||
| skipSelectors: {}, | ||
| facetsToInit: {}, | ||
| facetsToInit: { |
There was a problem hiding this comment.
If we are adding new interfaceIds here I believe migrations scripts should also be responsible for removing old facets interfaceIds from diamond-supported interfaces.
There was a problem hiding this comment.
would be good to validate this in upgrade tests too
There was a problem hiding this comment.
There are two things:
- first we have "initialized interfaces", which are stored in
ps.initializedInterfacesand are used by theonlyUninitializedmodifier. This value can currently be set to true only by callinginitialize, that's why I added them here. If I didn't, well, I don't think anything bad could happen. It's more of a consistency thing. This value is a bit peculiar since it can only be turned to true and not back to false (currently). I'm happy to discuss if we even need this initialization pattern or if should we simply deprecate it. Since initialize should never be registered as a diamond method, I don't see a security risk there if we omitonlyUninitializedfrom facets in the upcoming releases. - Then we also have "supported Interfaces" which are stored in
ds.supportedInterfacesand are used when someone querieserc165.supportsInterface. The upgrade script already passes a list ofinterfaceIdsto add and remove toProtocolInitializationHandlerFacetwhen the diamond cut is made. So no need to do any changes to those scripts. But yeah, it might be worth adding that to generic upgrade tests, since I assume most upgrades will change at least some interfaces.
There was a problem hiding this comment.
IMO modifiers should be used for security reasons and if this modifier is not prevent anything bad from happening I vote for removing
There was a problem hiding this comment.
added an issue just to not ended up loosing this discussion as I'm going to merge this PR
2.2.0 fix metaTransaction initialization
Release 2 2 0
anajuliabit
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes the changes for upgrade 2.1.0->2.2.0