Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ether.js v6 migration #688

Merged
merged 33 commits into from
Jul 4, 2023
Merged

ether.js v6 migration #688

merged 33 commits into from
Jul 4, 2023

Conversation

anajuliabit
Copy link
Contributor

@anajuliabit anajuliabit commented Jun 15, 2023

Remediate #678

dependabot bot and others added 5 commits June 8, 2023 22:01
Bumps [@nomicfoundation/hardhat-toolbox](https://github.com/nomicfoundation/hardhat) from 2.0.2 to 3.0.0.
- [Release notes](https://github.com/nomicfoundation/hardhat/releases)
- [Commits](https://github.com/nomicfoundation/hardhat/compare/@nomicfoundation/hardhat-toolbox@2.0.2...@nomicfoundation/hardhat-toolbox@3.0.0)

---
updated-dependencies:
- dependency-name: "@nomicfoundation/hardhat-toolbox"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@anajuliabit anajuliabit marked this pull request as ready for review June 27, 2023 00:31
@anajuliabit
Copy link
Contributor Author

@zajck good catches, I applied all!

@anajuliabit anajuliabit requested a review from zajck June 27, 2023 18:08
@coveralls
Copy link

coveralls commented Jun 28, 2023

Coverage Status

coverage: 99.702% (-0.03%) from 99.733% when pulling 353cb4d on etherv6_migration into ab3d4ba on main.

@anajuliabit anajuliabit changed the title Etherv6 migration ether.js v6 migration Jun 28, 2023
Copy link
Member

@zajck zajck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a few things that I couldn't comment directly:

  • There's another case of toHexString
    const pBuffer = Buffer.from(slot.toHexString().slice(2), "hex");
  • in test/util/upgrade.js, we have BigInt.toNumber() in some places and it should be changed to Number(BigInt). This happens on lines 470, 523, 539, 540, 620, 1236*, 1365*, 1392*, 1679, 1733. In those marked with * you can probably even get rid of all casting and just assign store to variable whatever getStorageAt returns

I guess these are my last requests. If we miss something in the upgrade test files, I'll find it anyway when I merge this into upgrade tests.

test/domain/OfferDatesTest.js Outdated Show resolved Hide resolved
test/util/upgrade.js Outdated Show resolved Hide resolved
test/util/upgrade.js Outdated Show resolved Hide resolved
test/upgrade/clients/01_generic.js Outdated Show resolved Hide resolved
@anajuliabit anajuliabit force-pushed the etherv6_migration branch 2 times, most recently from 34df143 to 781ccaa Compare June 30, 2023 17:48
@anajuliabit anajuliabit force-pushed the etherv6_migration branch 2 times, most recently from abe78bd to 21d912b Compare June 30, 2023 19:37
@anajuliabit anajuliabit requested a review from zajck June 30, 2023 19:38
Copy link
Member

@zajck zajck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@mischat mischat merged commit 65f8f9a into main Jul 4, 2023
11 checks passed
@mischat mischat deleted the etherv6_migration branch July 4, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants