Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer validity period - include upper value #697

Merged
merged 10 commits into from
Jul 7, 2023
Merged

Conversation

zajck
Copy link
Member

@zajck zajck commented Jun 21, 2023

Close #696

@coveralls
Copy link

coveralls commented Jun 21, 2023

Coverage Status

coverage: 99.707%. remained the same when pulling 605df78 on offer-validity-period into c6d0e08 on main.

@mischat
Copy link
Member

mischat commented Jul 6, 2023

@zajck, it looks like we have some merge conflicts here ...

@mischat mischat added the v2.3.0 label Jul 7, 2023
Copy link
Contributor

@anajuliabit anajuliabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mischat mischat merged commit 8658b7a into main Jul 7, 2023
18 checks passed
@mischat mischat deleted the offer-validity-period branch July 7, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow commiting to offer when timestamp is offerDates.validUntil
4 participants