Clone vouchers using create2 #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes unknown when pulling 1ec9c3c on voucher-create2 into ** on main**. |
mischat
previously approved these changes
Jul 7, 2023
anajuliabit
suggested changes
Jul 7, 2023
| @@ -743,6 +837,73 @@ describe("ProtocolInitializationHandler", async function () { | |||
| ).to.be.revertedWith(RevertReasons.VALUE_ZERO_NOT_ALLOWED); | |||
| }); | |||
|
|
|||
| it("sellerIds and sellerCreators length mismatch", async function () { | |||
| // set invalid minResolutionPeriod | |||
There was a problem hiding this comment.
Suggested change
| // set invalid minResolutionPeriod |
| }); | ||
|
|
||
| it("invalid seller id ", async function () { | ||
| // set invalid minResolutionPeriod |
There was a problem hiding this comment.
Suggested change
| // set invalid minResolutionPeriod |
Comment on lines
+267
to
+271
| function getCloneByteCodeHash(beaconProxyAddress) { | ||
| return keccak256( | ||
| `0x3d602d80600a3d3981f3363d3d373d3d3d363d73${beaconProxyAddress.slice(2)}5af43d82803e903d91602b57fd5bf3` | ||
| ); | ||
| } |
There was a problem hiding this comment.
where did you get this value? would be nice to have some comments here :)
There was a problem hiding this comment.
I got it from our contracts, but otherwise this is EIP 1167 style minimal clone.
We use the code from this example.
OZ uses the same: https://blog.openzeppelin.com/deep-dive-into-the-minimal-proxy-contract
anajuliabit
previously approved these changes
Jul 7, 2023
Co-authored-by: Ana Julia Bittencourt <anajuliabit@gmail.com>
mischat
approved these changes
Jul 7, 2023
anajuliabit
approved these changes
Jul 7, 2023
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #702
Based on #592 which should be merged first.
Changes:
create2instead ofcreateincloneBosonVoucherBeaconClientProxyis deployed from the protocol.