-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remmediate [PIH-01M] Inexistent Support of Manual Seller Configuration #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajck
force-pushed
the
audit_v2_3_0_pih_01_m
branch
from
August 9, 2023 05:51
53c33cb
to
33a73c2
Compare
zajck
force-pushed
the
audit_v2_3_0_pih_01_m
branch
from
August 23, 2023 06:49
1027b51
to
6bc7eec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zajck I've left a small question
albertfolch-redeemeum
previously approved these changes
Aug 24, 2023
…n-protocol-contracts into audit_v2_3_0_pih_01_m
levalleux-ludo
previously approved these changes
Aug 25, 2023
albertfolch-redeemeum
previously approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
levalleux-ludo
dismissed stale reviews from albertfolch-redeemeum and themself
via
August 25, 2023 08:51
7c277e7
Co-authored-by: albertfolch-redeemeum <102516373+albertfolch-redeemeum@users.noreply.github.com>
levalleux-ludo
approved these changes
Aug 25, 2023
albertfolch-redeemeum
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728
Based on #746 which should be reviewed and merged first.
Instead of backfilling the data at the initialization time, seller salts are now generated
updateSellerSalt
Due to the changes in #746 it will be possible that the same wallet creates multiple seller ids. It's also possible that already now there exist seller accounts with the same creator address. To avoid collisions, seller salt is now derived from the admin address and the user-supplied salt.
Since this is a user-defined value, we cannot just pick it on the sellers' behalf.
Two view methods were added to check if the chosen salt will result in successful clone creation:
isSellerSaltAvailable
can be used before callingcreateSeller
,createNewCollection
(for sellers from before v2.3.0 which might not have seller salt initialized yet) orupdateSellerSalt
calculateCollectionAddress
can be used to get both the expected collection address and its availability.