Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remediate [SHF-01M] Incorrect Iterator Usage #748

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Remediate [SHF-01M] Incorrect Iterator Usage #748

merged 2 commits into from
Aug 8, 2023

Conversation

zajck
Copy link
Member

@zajck zajck commented Aug 3, 2023

Fix #730

@zajck zajck added bug Something isn't working v2.3.0 labels Aug 3, 2023
@zajck zajck self-assigned this Aug 3, 2023
@coveralls
Copy link

coveralls commented Aug 3, 2023 •
edited
Loading

Coverage Status

coverage: 99.738%. remained the same when pulling a346915 on audit_v2_3_0_shf_01_m into d69e03d on main.

mischat
mischat approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me !

@anajuliabit anajuliabit merged commit 9070c04 into main Aug 8, 2023
9 checks passed
@mischat mischat deleted the audit_v2_3_0_shf_01_m branch August 8, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischat mischat mischat approved these changes

@anajuliabit anajuliabit anajuliabit approved these changes

Assignees

@zajck zajck

Labels
bug Something isn't working v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SHF-01M] Incorrect Iterator Usage
4 participants
@zajck @coveralls @mischat @anajuliabit