Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise dispute only once even if multiple twin transfers fail #759

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Raise dispute only once even if multiple twin transfers fail #759

merged 4 commits into from
Aug 28, 2023

Conversation

zajck
Copy link
Member

@zajck zajck commented Aug 7, 2023

fix #758

Fix required some additional refactoring to avoid stack too deep error.

@zajck zajck self-assigned this Aug 7, 2023
@zajck zajck added bug Something isn't working Refactor v2.3.0 labels Aug 7, 2023
@coveralls
Copy link

coveralls commented Aug 7, 2023 •
edited
Loading

Coverage Status

coverage: 99.582% (+0.002%) from 99.58% when pulling c773419 on twin-transfer-raise-dispute-once into c11764c on main.

@zajck zajck mentioned this pull request Aug 10, 2023
Merged
albertfolch-redeemeum
albertfolch-redeemeum previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mischat
mischat approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sane. thanks

@mischat mischat merged commit a79e24c into main Aug 28, 2023
9 checks passed
@mischat mischat deleted the twin-transfer-raise-dispute-once branch August 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertfolch-redeemeum albertfolch-redeemeum albertfolch-redeemeum approved these changes

@mischat mischat mischat approved these changes

@anajuliabit anajuliabit Awaiting requested review from anajuliabit

Assignees

@zajck zajck

Labels
bug Something isn't working Refactor v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If multiple twin transfer fail, dispute is raised multiple times
4 participants
@zajck @coveralls @mischat @albertfolch-redeemeum