Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.3.0 upgrade tests #801

Merged
merged 5 commits into from
Sep 13, 2023
Merged

2.3.0 upgrade tests #801

merged 5 commits into from
Sep 13, 2023

Conversation

zajck
Copy link
Member

@zajck zajck commented Sep 7, 2023

Continue work from #680

  • removed the unnecessary minting of twins
  • enabled back skipped tests
  • added tests for new private variables

@zajck zajck added enhancement New feature or request v2.3.0 labels Sep 7, 2023
@zajck zajck self-assigned this Sep 7, 2023
@coveralls
Copy link

Coverage Status

coverage: 99.559%. remained the same when pulling ad224ba on 2.3.0-upgrade-tests into aab19d9 on main.

mischat
mischat approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, i guess @albertfolch-redeemeum and @levalleux-ludo should review too

levalleux-ludo
levalleux-ludo approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mischat mischat merged commit 5321ad8 into main Sep 13, 2023
10 checks passed
@mischat mischat deleted the 2.3.0-upgrade-tests branch September 13, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischat mischat mischat approved these changes

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

@albertfolch-redeemeum albertfolch-redeemeum Awaiting requested review from albertfolch-redeemeum

Assignees

@zajck zajck

Labels
enhancement New feature or request v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zajck @coveralls @mischat @levalleux-ludo