Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance commit to offer meta tx message #817

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zajck
Copy link
Member

@zajck zajck commented Oct 27, 2023

Closes #815

Currently, when a buyer is committing to an offer via metaTransaction, the only displayed value is offerId.

With this PR, the message to sigh is changed to contain other offer parameters:

  • exchange token
  • price
  • seller deposit
  • buyer cancellation penalty
  • the start of the redemption period (in the format yyyy/mm/dd hh:mm:ss)
  • dispute period duration (in days)
  • resolution period duration (in days)

Note: changes apply only to metatransaction. Committing to the offer directly still requires only the offerId.

@coveralls
Copy link

Coverage Status

coverage: 99.56% (+0.001%) from 99.559% when pulling fa2c48d on meta-tx-enhance-commit-to-offer-nicer into 9cc931b on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol - MetaTx Changes to Legibility
2 participants