V2.4.0. protocol initialization #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -94,21 +94,23 @@ contract ProtocolInitializationHandlerFacet is IBosonProtocolInitializationHandl | |||
| } | |||
| } | |||
|
|
|||
| ProtocolLib.ProtocolStatus storage status = protocolStatus(); | |||
| // ProtocolLib.ProtocolStatus storage status = protocolStatus(); | |||
There was a problem hiding this comment.
remove comment
| /** | ||
| * @notice Initializes the version 2.4.0. | ||
| * | ||
| * Initliaziation data is used to back-fill the royalty recipients for existing offers and sellers. |
There was a problem hiding this comment.
Suggested change
| * Initliaziation data is used to back-fill the royalty recipients for existing offers and sellers. | |
| * Initialization data is used to back-fill the royalty recipients for existing offers and sellers. |
| * Supplied royalty percentage should match the current percentage set in seller's boson voucher contract. | ||
| * If seller has multiple collections with different royalty precentages: | ||
| * - the sellerId should be included in the group, corresponding to the minimal royalty percentage | ||
| * - the _offerIds array should should be included in the group, corresponding to the royalty percentage that matches the royalty of the collection to which offer belongs |
There was a problem hiding this comment.
Suggested change
| * - the _offerIds array should should be included in the group, corresponding to the royalty percentage that matches the royalty of the collection to which offer belongs | |
| * - the _offerIds array should be included in the group, corresponding to the royalty percentage that matches the royalty of the collection to which offer belongs |
| /** | ||
| * @notice Method to initialize the protocol if it cannot be done in a single transaction. | ||
| * | ||
| * This shuld be used only if the amount of data is too large, and it cannot be done in a single `initialize` transaction. |
There was a problem hiding this comment.
Suggested change
| * This shuld be used only if the amount of data is too large, and it cannot be done in a single `initialize` transaction. | |
| * This should be used only if the amount of data is too large, and it cannot be done in a single `initialize` transaction. |
albertfolch-redeemeum
previously approved these changes
Dec 6, 2023
albertfolch-redeemeum
approved these changes
Dec 7, 2023
levalleux-ludo
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent changes, existing sellers are missing
royaltyRecipientsand offers are missingroyaltyInfo.This data should be filled in during the initialization of the next version.
This PR adds
initV2_4_0which is used to populate missing data.