Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Royalty registry integration test #840

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Royalty registry integration test #840

merged 8 commits into from
Dec 11, 2023

Conversation

zajck
Copy link
Member

@zajck zajck commented Dec 8, 2023

Changes:

  • make getRoyalties compatible with the royalty registry, so it can be used as an "override" in RR, when a seller uses multiple recipients
  • adapt royalty registry integration tests to work with updated packages
  • add "multiple recipient" tests to royalty registry integration test

@zajck zajck added bug Something isn't working v2.4.0 labels Dec 8, 2023
@zajck zajck self-assigned this Dec 8, 2023
@coveralls
Copy link

coveralls commented Dec 8, 2023 •
edited
Loading

Coverage Status

coverage: 98.629% (+0.002%) from 98.627%
when pulling 081d35f on integration-royalty-registry
into 0a6566f on main.

@zajck zajck merged commit ab10b47 into main Dec 11, 2023
12 checks passed
@zajck zajck deleted the integration-royalty-registry branch December 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertfolch-redeemeum albertfolch-redeemeum albertfolch-redeemeum approved these changes

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

Assignees

@zajck zajck

Labels
bug Something isn't working v2.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zajck @coveralls @levalleux-ludo @albertfolch-redeemeum