Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price discovery offers must have 0 initial price #909

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Price discovery offers must have 0 initial price #909

merged 3 commits into from
Feb 16, 2024

Conversation

zajck
Copy link
Member

@zajck zajck commented Feb 16, 2024

Fix #907

@zajck zajck added the bug Something isn't working label Feb 16, 2024
@zajck zajck self-assigned this Feb 16, 2024
@coveralls
Copy link

Coverage Status

coverage: 98.926% (+0.001%) from 98.925%
when pulling c0a30c4 on pd-offer-non-zero-price
into 9ed49d7 on main.

@zajck zajck added the v2.4.0 label Feb 16, 2024
@zajck zajck enabled auto-merge (squash) February 16, 2024 16:00
@zajck zajck merged commit ed67b23 into main Feb 16, 2024
11 checks passed
@zajck zajck deleted the pd-offer-non-zero-price branch February 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

@albertfolch-redeemeum albertfolch-redeemeum albertfolch-redeemeum approved these changes

Assignees

@zajck zajck

Labels
bug Something isn't working v2.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer of type "discovery" should have 0 offer price
4 participants
@zajck @coveralls @levalleux-ludo @albertfolch-redeemeum