cmd/scollector: process_linux process start_time and uptime #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,6 +110,8 @@ func linuxProcMonitor(w *WatchedProc, md *opentsdb.MultiDataPoint) error { | |||
| Add(md, "linux.proc.io_bytes", io[4], opentsdb.TagSet{"type": "read"}.Merge(tags), metadata.Counter, metadata.Bytes, descLinuxProcIoBytesRead) | |||
| Add(md, "linux.proc.io_bytes", io[5], opentsdb.TagSet{"type": "write"}.Merge(tags), metadata.Counter, metadata.Bytes, descLinuxProcIoBytesWrite) | |||
| Add(md, "linux.proc.num_fds", len(fds), tags, metadata.Gauge, metadata.Files, descLinuxProcFd) | |||
| Add(md, "linux.proc.start_time", start_ts, tags, metadata.Gauge, metadata.Timestamp, descLinuxProcStartTS) | |||
| Add(md, "linux.proc.uptime", timestamp-start_ts, tags, metadata.Gauge, metadata.Second, descLinuxProcUptime) | |||
There was a problem hiding this comment.
This is not the uptime of the program. It is the uptime of the program since scollector has been running. I don't see the value of this metric, since one can always just subtract the start time and a timestamp to figure out uptime.
There was a problem hiding this comment.
Nope, I'm wrong. timestamp is updated to be now. But use now() to get it because it's race-free.
d10v
force-pushed
the
process-linux-starttime
branch
from
a6363d9 to
d49b92f
Compare
| @@ -91,6 +97,8 @@ func linuxProcMonitor(w *WatchedProc, md *opentsdb.MultiDataPoint) error { | |||
| } | |||
| } | |||
| } | |||
| start_ts := file_status.ModTime().Unix() | |||
| now := time.Now().Unix() | |||
There was a problem hiding this comment.
Just use now() for this:
bosun/cmd/scollector/collectors/collectors.go
Line 107 in 3e9002e
d10v
force-pushed
the
process-linux-starttime
branch
from
d49b92f to
9fe0b0d
Compare
maddyblue
added a commit
that referenced
this pull request
Jun 22, 2015
cmd/scollector: process_linux process start_time and uptime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate process start time and uptime from file stat data of /proc/ directory.
P.S. Chose this because it's way simpler than querying uptime,
getconf CLK_TCK, parsing stat and jiffies. There were times when/proc/<pid>stat data was modifiable but that's fixed now.