cmd/bosun: download entire alerts dashboard at once #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyblue
force-pushed
the
dashboard-perf
branch
from
1cd204d to
06b9f2d
Compare
|
LGTM. What is wrong with the travis build? |
maddyblue
added a commit
that referenced
this pull request
Jun 30, 2015
cmd/bosun: download entire alerts dashboard at once
Previously, only a summary of each alert was downloaded. This was because the entire struct was large (hundreds of megs) due to computations. Since we have removed computations from the dashboard, we can now again download the entire struct. The bug this new method prevents is that if an alert has changed since the dashboard summary was downloaded, it will no longer show up in the wrong place. The dashboard is now faster because it does not download each alert when a group is expanded. Testing with our production state file, this route went from 6K to 900K. A substantial increase, but still small and fast enough to be fine. fixes #1094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only a summary of each alert was downloaded. This was because
the entire struct was large (hundreds of megs) due to computations. Since
we have removed computations from the dashboard, we can now again download
the entire struct. The bug this new method prevents is that if an alert has
changed since the dashboard summary was downloaded, it will no longer show
up in the wrong place. The dashboard is now faster because it does not
download each alert when a group is expanded.
Testing with our production state file, this route went from 6K to 900K. A
substantial increase, but still small and fast enough to be fine.
fixes #1094