collect: Instrument aggregation stats for http post timings #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| descCollectPostError = "Counter of errors received when sending a batch to the server." | ||
| descCollectPostBad = "Counter of HTTP POST requests where resp.StatusCode != http.StatusNoContent." | ||
| descCollectPostRestore = "Counter of data points restored from batches that could not be sent to the server." | ||
| descCollectDropped = "Counter of dropped data points due to the queue being full." |
There was a problem hiding this comment.
Since we touched this block, can we alphabetize the constants?
There was a problem hiding this comment.
@captncraig Can do that, but can that be added somewhere? style guide, contributing etc
|
lgtm |
Also updated the AggregateMeta function
kylebrandt
force-pushed
the
instCollectPost
branch
from
ab4aecf to
1380ed6
Compare
kylebrandt
added a commit
that referenced
this pull request
Jul 9, 2015
collect: Instrument aggregation stats for http post timings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the AggregateMeta function