Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun: Button to download config to local machine #1164

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Conversation

captncraig
Copy link
Contributor

screen shot 2015-07-14 at 10 57 44 am

Relies on browser's save dialog. Intent is user can save wherever they choose and upload to git or server or whatever.

@gbrayut
Copy link
Contributor

gbrayut commented Jul 14, 2015

Tested locally and works as expected but TravisCI is complaining:

Running go generate bosun.org/...
2015/07/14 17:01:17 running tsc
web/static/js/config.ts(400,3): error TS2304: Cannot find name 'saveAs'.
2015/07/14 17:01:19 run error: tsc: exit status 2
2015/07/14 17:01:19 run complete: tsc
2015/07/14 17:01:19 running esc
2015/07/14 17:01:20 run complete: esc
Go generate needs to be run. The following files have changed:
cmd/bosun/web/static.go

@kylebrandt
Copy link
Member

Looks okay to me once it passed the build.

captncraig pushed a commit that referenced this pull request Aug 26, 2015
cmd/bosun: Button to download config to local machine
@captncraig captncraig merged commit 3776949 into master Aug 26, 2015
@captncraig captncraig deleted the saveButton branch August 26, 2015 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants