cmd/bosun: Refactor filter expr func to also filter out zero valued results #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults (false) This is a breaking change. Fixes #1100
| @@ -360,7 +360,9 @@ func Filter(e *State, T miniprofiler.Timer, series *Results, number *Results) (* | |||
| for _, sr := range series.Results { | |||
| for _, nr := range number.Results { | |||
| if sr.Group.Subset(nr.Group) || nr.Group.Subset(sr.Group) { | |||
| ns = append(ns, sr) | |||
| if nr.Value.Value().(Number) != 0 { | |||
There was a problem hiding this comment.
This type of type assertion will panic if anything but a number makes it here.
There was a problem hiding this comment.
@captncraig I'm aware but throughout the funcs.go we don't check them since the map[string]parse.Func{... ensures we won't get there.
captncraig
changed the title
captncraig
added a commit
that referenced
this pull request
Jul 27, 2015
cmd/bosun: Refactor filter expr func to also filter out zero valued results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esults (false)
This is a breaking change. Fixes #1100