support configuring misc http headers for Graphite requests #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good to me. What is you use case for this? |
|
We use the litmus graphite-kairosdb storage plugin which uses an x-org-id header for authorization |
|
Litmus is raintanks upcoming sass monitoring product (for context)
|
captncraig
added a commit
that referenced
this pull request
Jul 30, 2015
support configuring misc http headers for Graphite requests
| @@ -44,6 +44,7 @@ Every variable is optional, though you should enable at least 1 backend. | |||
| * The items page. | |||
| * The graph page's tag list. | |||
| * graphiteHost: an ip, hostname, ip:port, hostname:port or a URL, defaults to standard http/https ports, defaults to "/render" path. Any non-zero path (even "/" overrides path) | |||
| * graphiteHeader: a http header to be sent to graphite on each request in 'key:value' format. optional. can be specified multiple times. | |||
There was a problem hiding this comment.
I think you must add an exception to the seen func to make this specifiable multiple times.
There was a problem hiding this comment.
you're right, fixed in #1234
thanks for still looking out matt ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.