cmd/scollector: Monitoring teams interfaces #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
force-pushed
the
linuxInterfaceTeam
branch
from
c9fc584 to
7ccd2ad
Compare
kylebrandt
changed the title
| func c_if_bond_linux() (opentsdb.MultiDataPoint, error) { | ||
| var md opentsdb.MultiDataPoint | ||
| const bondingPath = "/proc/net/bonding" | ||
| bondDevices, _ := ioutil.ReadDir(bondingPath) |
There was a problem hiding this comment.
unchecked errors are bad. Especially in a case like this where the path might not exist.
Currently we monitor bonding which works with CentOS 6, but by default CentOS 7 is using teaming and we want to monitor that as well. Also moved bonding monitoring to the ifstat collector and out of procstat.
kylebrandt
force-pushed
the
linuxInterfaceTeam
branch
from
7ccd2ad to
c10fca3
Compare
kylebrandt
added a commit
that referenced
this pull request
Aug 28, 2015
cmd/scollector: Monitoring teams interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we monitor bonding which works with CentOS 6, but by default CentOS 7 is using teaming and we want to monitor that as well.