Updating dependencies #1369
Merged
Updating dependencies #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could change the import for snmp to bosun-monitor/snmp now? I don't know if it fits in your schedule though. |
|
Yeah, I'll be doing that. Actually playing with godep instead of party for vendoring at the moment. I'll move snmp as part of that. |
|
godep or gb :). 👍 for anything that uses a 'vendor' dir, and no rewriting. |
|
@giganteous we are probably going to stick with rewriting until GOVENDOREXPERIMENT becomes a default. Maybe. It is important to us that Setting the env var is not difficult, but it is another step. Bring it up in slack if you feel strongly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.