-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nexpose collector. #1407
Add nexpose collector. #1407
Conversation
Very cool. Forwarding to my infosec group...
|
|
||
func c_nexpose(username, password, host string, insecure bool) (opentsdb.MultiDataPoint, error) { | ||
tr := &http.Transport{ | ||
TLSClientConfig: &tls.Config{InsecureSkipVerify: insecure}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting the irony of even having an insecure option for a vulnerability tool. If insecure is false, you can just use http.DefaultClient.
For dealing with 2 versions of xml apis and the worst json api I've ever seen, I'd say it looks pretty good. |
c2a14be
to
70e4d2b
Compare
@captncraig Requested changes made. I've left the fixup commits separate to facilitate easy review. Will squash before merge. |
@alienth I really like how you address individual issues with separate commits. Good call. Merge at will. |
40e9b80
to
695c721
Compare
Looking for an initial review pass on this collector.
Collector is configured as follows:
For each monitored asset, it sends metrics with the vuln count, malware count, risk score, exploit count, and last scan time (represented in seconds since last scan). The asset
name
is either the detected hostname, or the IP address of the host.For each site, it sends
nexpose.site
metrics which are an aggregate of the aforementioned device metrics.It also sends a
nexpose.scan.running
metric indicating if a scan is currently running on a site.Note that not all of the defined functions are used at this time. They'll probably come in handy for other metrics, so I'd like to keep em in. I'll probably end up creating a generic Go package for nexpose and rip a lot of that stuff out of this collector.
👓 @kylebrandt @captncraig