Add ciscobgp snmp collector #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +62,21 @@ const ( | |||
| ) | |||
|
|
|||
| const ( | |||
| bgpPeerState = "bgp.peer.state" | |||
There was a problem hiding this comment.
you can actually define these inside of the collector function that uses them. I think doing that may help keep the collectors package from having quite so many symbols defined at package scope.
There was a problem hiding this comment.
Will do - was following the conventions from snmp_ifaces which I assumed were an attempt to enable easier localization of these strings?
|
Overall looks pretty solid. Just a few minor things to look at, to make sure this won't panic on us. |
shanemadden
added a commit
that referenced
this pull request
Oct 22, 2015
Add ciscobgp snmp collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SNMP collector for the gathering of BGP health data from Cisco devices (CISCO-BGP4-MIB).