Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Incident Redis Refactoring Madness #1497

Merged
merged 1 commit into from
Feb 3, 2016
Merged

WIP Incident Redis Refactoring Madness #1497

merged 1 commit into from
Feb 3, 2016

Conversation

captncraig
Copy link
Contributor

  • alerts run
  • dashboard renders
  • unknowns trigger
  • incident view working
  • alert counts reporting
  • restore historical incidents
  • action notifications working again
  • tests passing
  • dependency function working.

@@ -2,6 +2,7 @@ package sched

import (
"fmt"
"log"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be using slog

@kylebrandt
Copy link
Member

Bug: Dashboard shows alert key now instead of subject:

Master:
image

Branch:
image

@kylebrandt
Copy link
Member

Bug: Full History links on dashboard don't work anymore:
Link:
image

View:
image

@kylebrandt
Copy link
Member

Bug: Dashboard alert expands that show the template body no longer work:

Master:
image

Branch:
image

@kylebrandt
Copy link
Member

Bug: Silence doesn't show alert will be silenced when using test on the silence page:

Master:
image

Branch:
image

@kylebrandt
Copy link
Member

Bug? Stuff still gets written to bold when stopping bosun:

2016/01/08 10:19:15 info: bolt.go:76: wrote notifications: 48.00B 2016/01/08 10:19:15 info: bolt.go:100: save to db complete

@kylebrandt
Copy link
Member

Bug? Migrating state runs on a second run, not just the first according to the log:

2016/01/08 10:21:21 info: bolt.go:487: migrating state

@kylebrandt
Copy link
Member

Bug: New template erros on many alerts that we don't see on prod:

2016/01/08 10:22:08 info: check.go:240: hardware{host=nyhq-fs01}: template: hardware:1:65: executing "hardware" at <.Group.host>: Group is not a field of struct type *sched.Context 2016/01/08 10:22:08 info: check.go:253: hardware{host=nyhq-fs01}: template: header:10:19: executing "header" at <.Group.host>: Group is not a field of struct type *sched.Context 2016/01/08 10:22:08 info: check.go:266: hardware{host=nyhq-fs01}: template: header:10:19: executing "header" at <.Group.host>: Group is not a field of struct type *sched.Context 2016/01/08 10:22:08 info: check.go:279: hardware{host=nyhq-fs01}: template: hardware:1:65: executing "hardware" at <.Group.host>: Group is not a field of struct type *sched.Context

@kylebrandt
Copy link
Member

Bug: Historical testing doesn't seem to work:

Master:
image

Branch:
image

@captncraig
Copy link
Contributor Author

Multiple migrations fixed. May need to flush redis to avoid duplicate data.

@kylebrandt
Copy link
Member

2016/01/19 09:44:27 info: check.go:256: hardware{host=ny-sql04}: template: header:22:48: executing "header" at <.Last.IncidentId>: IncidentId is not a field of struct type models.Event 2016/01/19 09:44:27 info: check.go:269: hardware{host=ny-sql04}: template: header:22:48: executing "header" at <.Last.IncidentId>: IncidentId is not a field of struct type models.Event

@kylebrandt
Copy link
Member

image

@kylebrandt
Copy link
Member

image

@captncraig captncraig merged commit 18fb20e into master Feb 3, 2016
@captncraig captncraig deleted the incidentState branch February 3, 2016 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants