cmd/scollector+bosun: get vsphere mounted datastores and expose via h… #1515
Conversation
| dataStores := []string{} | ||
| err = json.Unmarshal([]byte(val), &dataStores) | ||
| if err != nil { | ||
| slog.Errorf("error unmarshalling datastores for host %s while generating host api: %s", host.Name, err) |
There was a problem hiding this comment.
continue or return here. Don't keep going.
There was a problem hiding this comment.
@captncraig Since the host API generates a lot of information, I don't want single errors preventing the rest of the information from being returned
There was a problem hiding this comment.
yeah, then we chould continue the metadata loop. Should not iterate over dataStores if we just failed to deserialize it.
There was a problem hiding this comment.
@captncraig My assumption was that in we fail to deserialize it, the array will be empty, so the range is a no-op.
There was a problem hiding this comment.
It is possible it has a few partial objects already created there. I'd rather skip it to be safe.
There was a problem hiding this comment.
@captncraig The code makes it sounds like it checks for this first, see https://golang.org/src/encoding/json/decode.go?s=2621:2669#L64
"""
// Check for well-formedness.
// Avoids filling out half a data structure
// before discovering a JSON syntax error.
"""
…ost api