cmd/bosun: Shorten-only http proxy #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Silly question: what problem does this solve? |
|
Our outbound proxies are on a different network than where OpentTSDB is. In our case we simply cannot use the same for both sets of calls. I also think going through a proxy to fetch data from OpenTSDB is generally unneeded in most deployments, unlike reaching out to googleapis. |
|
yeah... Internet calls vs Intranet calls makes sense. I'd change the name to InternetProxy so it can be reused if we ever add any other APIs, but otherwise sounds fine to me. |
| if *flagQuiet { | ||
| c.Quiet = true | ||
| } | ||
| go func() { slog.Fatal(web.Listen(c.HTTPListen, *flagDev, c.TSDBHost)) }() | ||
| go func() { slog.Fatal(web.Listen(c.HTTPListen, *flagDev, c.TSDBHost, shortenProxy)) }() |
There was a problem hiding this comment.
I don't love the idea of yet another argument to Listen. How about a package variable in web that you set when reading the config above here?
mathpl
force-pushed
the
feature/shorten_only_proxy
branch
2 times, most recently
from
3098748 to
9768b90
Compare
mathpl
force-pushed
the
feature/shorten_only_proxy
branch
from
9768b90 to
5e9cdec
Compare
|
How about this? |
|
Thanks for those changes. I like it. |
|
LGTM |
captncraig
pushed a commit
that referenced
this pull request
Feb 12, 2016
cmd/bosun: Shorten-only http proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds shortenProxy as option in bosun.toml to add a proxy only to requests out to googleapis' shortener api. The alternative is making use of the default http client's http.ProxyFromEnvironment but it results in all http calls to use it. That includes calls to OpenTSDB which isn't a something we want.