cmd/scollector: negative -f filters and total_time metric for httpunit collector #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative filter patterns ("-" prefix),
Added time_total metric to httpunit collector,
Freq setting for HTTPUnit collectors.
also add a log message when metrics are being filtered since I spent 20 minutes trying to figure out why my -p and -f tests were not working closes #1263
| return nil | ||
| } | ||
|
|
||
| func HTTPUnitPlans(name string, plans *httpunit.Plans) { | ||
| func HTTPUnitPlans(name string, plans *httpunit.Plans, freq time.Duration) { | ||
| if freq < time.Second { |
There was a problem hiding this comment.
this seems a bit odd to me. If they didn't set it, and it was zero, I would understand. But if they set 15 expecting it to be seconds or minutes or who knows what, 5 mins is an odd default. Maybe error with a helpful message?
|
Other than craig being confused about timings, it looks good to me. |
|
@captncraig I changed it to use a duration string... will be clearer in the config files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #1263 rebased on current master and with more documentation