cmd/scollector: Additional functionality into ExtraHop collector #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, v := range extraHopAdditionalMetrics { | ||
| metric, err := gohop.StoEHMetric(v) | ||
| if err != nil { | ||
| log.Println(err) |
There was a problem hiding this comment.
continue or return so main logic isn't indented.
mhenderson-so
force-pushed
the
ExtraHopMetrics
branch
6 times, most recently
from
90be7b9 to
7f4c67c
Compare
… specifying additional keyed metrics to be collected
mhenderson-so
force-pushed
the
ExtraHopMetrics
branch
from
7f4c67c to
0e393a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional functionality into ExtraHop collector for specifying additional keyed metrics to be collected.
Also made some small formatting & comment changes to be in-line with Go standards.