-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map #1813
Map #1813
Conversation
evil evil code right now, just playing
So with this would all math functions going forward operate on |
@CheRuisiBesares This does solve that issue as a side effect but has more power. For instance, you can This doesn't have to be independent of making those functions accept both, we could do that. When I tried I had issue getting the branch to work. I think that maybe It requires that the parser does additional lookaheads to know when the return type is going to be. I was having trouble pulling that off. Although maybe after going through this and understanding this part of the code more it would be easier. Since we could still change math functions to take (and return, that is the harder part) multiple types down the road independently of map, what this effectively does is lower the priority on caring about that for now. When someone has some alerts to show that use a lot of these functions, and map is making it ugly as hell, then I think it would be better to figure out how to implement it at that point since we would have more user stories at that point. |
Good stuff! Makes sense to me. Excited to get my TI-89 on |
Looks ok to me. |
still needs docs