collect: creating buffer pool for sending datapoints #1838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor optimization that should reduce gc pressure in the collect package.
Tested with a simple app that sends batches of 300 data points to a local black hole server every 30ms. Monitored with expvarmon
super unscientific data:
Before:
After:
Notice difference in HeapAlloc and Alloc. gc time is pretty much negligible at this scale, but its always good to throw away less stuff.