Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect: creating buffer pool for sending datapoints #1838

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Conversation

captncraig
Copy link
Contributor

This is a minor optimization that should reduce gc pressure in the collect package.

Tested with a simple app that sends batches of 300 data points to a local black hole server every 30ms. Monitored with expvarmon

super unscientific data:

Before:
screen shot 2016-07-27 at 12 10 22 am

After:
screen shot 2016-07-27 at 12 12 27 am

Notice difference in HeapAlloc and Alloc. gc time is pretty much negligible at this scale, but its always good to throw away less stuff.

@gbrayut
Copy link
Contributor

gbrayut commented Jul 27, 2016

tested and LGTM

@gbrayut gbrayut merged commit d1b7d83 into master Jul 27, 2016
@gbrayut gbrayut deleted the bufferpool branch July 27, 2016 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants